Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded additional sources and ForceAzureDevCom sources switch #76964

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Jan 29, 2025

The forced azure-dev-com appears no longer necessary, and dotnet-core-internal tooling is already added from internal tools nuget.config

The forced azure-dev-com appears no longer necessary, and dotnet-core-internal tooling is already added from internal tools nuget.config
@mmitche mmitche requested a review from a team as a code owner January 29, 2025 21:45
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 29, 2025
@mmitche mmitche requested a review from dibarbet January 29, 2025 21:45
@mmitche
Copy link
Member Author

mmitche commented Jan 29, 2025

Another official build with these changes: https://dev.azure.com/dnceng/internal/_build/results?buildId=2631016&view=results

@mmitche
Copy link
Member Author

mmitche commented Jan 29, 2025

Official build failed. It looks like the update of the restore sources overrides the nuget.config. I think the solution is to add the Engineering nuget.org to the upstreams of dotnet-core-internal-tooling and get rid of all these property based feed settings. I've opened a ticket to get this done.

@mmitche
Copy link
Member Author

mmitche commented Jan 30, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants